breautek commented on issue #1422: URL: https://github.com/apache/cordova-ios/issues/1422#issuecomment-2065289819
> breautek hi! thanks a lot for your activity here. FBSDKCoreKit https://github.com/CocoaPods/Specs/blob/master/Specs/9/b/5/FBSDKCoreKit/17.0.0/FBSDKCoreKit.podspec.json#L13 is required 12.0 you can try add in any your plugin and do clean build. I still could not reproduce the issue. The config.xml gets copied into platform resources pretty early on in the prepare step. I don't quite remember exactly where it happens in the code. But here's what I did: I've created a test plugin to wrap around the podspec, the test plugin is effectively just has an empty package.json and the `plugin.xml` as follows: ```xml <?xml version="1.0" encoding="UTF-8"?> <plugin xmlns="http://apache.org/cordova/ns/plugins/1.0"; xmlns:rim="http://www.blackberry.com/ns/widgets"; xmlns:android="http://schemas.android.com/apk/res/android"; id="test-plugin" version="5.0.1-dev"> <name>test</name> <description>Cordova test Plugin</description> <platform name="ios"> <podspec> <config> <source url="https://cdn.cocoapods.org/"; /> </config> <pods use-frameworks="true"> <pod name="FBSDKCoreKit" spec="17.0.0"/> </pods> </podspec> </platform> </plugin> ``` I `npm pack` the plugin which gives a .tgz file. In a test cordova project, which was empty with no platforms or plugins installed with a base config.xml: ```xml <?xml version='1.0' encoding='utf-8'?> <widget id="io.cordova.hellocordova" version="1.0.0" xmlns="http://www.w3.org/ns/widgets"; xmlns:cdv="http://cordova.apache.org/ns/1.0";> <name>HelloCordova</name> <description>Sample Apache Cordova App</description> <author email="d...@cordova.apache.org" href="https://cordova.apache.org";> Apache Cordova Team </author> <content src="index.html" /> <allow-intent href="http://*/*"; /> <allow-intent href="https://*/*"; /> </widget> ``` I added my test-plugin using a command like: `cordova plugin add file:../test-plugin/test-plugin-1.0.0.tgz` The plugin gets added successfully. Not installed at this point because there are no platforms. Just added to the project. Then I add the platform: `cordova platform add ios` which this installs cordova-ios 7.1.0 The platform is added successfully, but it does fail to completley install the test plugin because the default deployment target is 11.0, as expected since we didn't explicitly declare an alternate `deployment-target` preference yet. So we modify our config.xml and add: ```xml <preference name="deployment-target" value="12.0" /> ``` and then run `cordova prepare ios`, which updates the Podfile and runs pod install, and the FBSDK is installed to the project as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
