dpogue opened a new pull request, #1700:
URL: https://github.com/apache/cordova-android/pull/1700

   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   Adds support for the more general `SplashScreenBackgroundColor` preference.
   
   
   ### Description
   <!-- Describe your changes in detail -->
   Sets the splashscreen background based on the following options (in order):
   * `AndroidWindowSplashScreenBackground` preference
   * `SplashScreenBackgroundColor` preference
   * `BackgroundColor` preference
   * `#ffffff` hardcoded
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Didn't seem like there were any existing unit tests for the splashscreen 
stuff, so I didn't update any tests.
   
   - [ ] This still needs to be tested manually in an Android project.
   
   
   ### Checklist
   
   - [ ] I've run the tests to see all new and existing tests pass
   - [ ] I added automated test coverage as appropriate for this change
   - [ ] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to