shajz opened a new pull request, #633:
URL: https://github.com/apache/cordova-cli/pull/633

   <!--
   Please make sure the checklist boxes are all checked before submitting the 
PR. The checklist is intended as a quick reference, for complete details please 
see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   
   n/a
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   
   Closes https://github.com/apache/cordova-cli/issues/625.
   
   Telemetry relies on the `insight` package, which is unmaintained and relies 
on the `request` package which has a CVE 
https://github.com/advisories/GHSA-p8p7-x288-28g6
   
   This is basically the same PR as 
https://github.com/apache/cordova-cli/pull/614 but it's now following this 
discussion with the backing of @breautek : 
https://github.com/apache/cordova-cli/pull/631#issuecomment-1856101038
   
   ### Description
   <!-- Describe your changes in detail -->
   
   Remove the telemetry feature entirely
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   
   Ran `npm run test` successfully
   
   ### Checklist
   
   - [x] I've run the tests to see all new and existing tests pass
   - [x] I added automated test coverage as appropriate for this change
   - [x] Commit is prefixed with `(platform)` if this change only applies to 
one platform (e.g. `(android)`)
   - [x] If this Pull Request resolves an issue, I linked to the issue in the 
text above (and used the correct [keyword to close issues using 
keywords](https://help.github.com/articles/closing-issues-using-keywords/))
   - [x] I've updated the documentation if necessary
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org
For additional commands, e-mail: issues-h...@cordova.apache.org

Reply via email to