breautek opened a new pull request, #632: URL: https://github.com/apache/cordova-cli/pull/632
<!-- Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines: http://cordova.apache.org/contribute/contribute_guidelines.html Thanks! --> ### Platforms affected CLI ### Motivation and Context <!-- Why is this change required? What problem does it solve? --> <!-- If it fixes an open issue, please link to the issue here. --> closes #625 Insight is no longer maintained and it contains sub-dependencies with moderate vulnerabilities. ### Description <!-- Describe your changes in detail --> All code relating to telemetry and using Insight have been commented out. Fake implementations were left in place so our Telemetry API still exists, just it will always "opt out" of telemetry. This is done so that we can easily bring back telemetry later once we find a replacement for Insight. Tests related to telemetry were disabled. This PR is intended to be a stopgap just to resolve the present audit issues. ### Testing <!-- Please describe in detail how you tested your changes. --> Ran `npm test` ### Checklist - [x] I've run the tests to see all new and existing tests pass - [x] I added automated test coverage as appropriate for this change - [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`) - [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/)) - [x] I've updated the documentation if necessary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
