ath0mas commented on PR #581: URL: https://github.com/apache/cordova-plugin-file/pull/581#issuecomment-1692491284
To me, `hasReadPermission` and `hasWritePermission` should be left unchanged, because they already return the correct status for `*_EXTERNAL_STORAGE` permissions - if considering it strictly. And, as I work on PR #597, I like the idea that this plugin should concentrate on file operations among the app dirs only, default authorized without any permission ; and that trying to read-write outside should be done using other plugins, to follow the concepts and isolation forced by Google for file-sharing between apps or publicly, relying on SAF, MediaStore, ContentProvider, etc. --- For more tech review: - `getWritePermission(` is supposed to continue through its `callbackContext` param, and permission process, and so doing nothing in the `if` you added seems wrong -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@cordova.apache.org For additional commands, e-mail: issues-h...@cordova.apache.org
