ollm commented on PR #1333: URL: https://github.com/apache/cordova-ios/pull/1333#issuecomment-1570338827
Currently I only check if `sourceFrame` is `null`, in the plugin I'm working on, when clicked on links inside iframes they have to open in the browser, and some website iframes in particular (It happens to me in Youtube Video Iframe and AdSense Ad), when clicked the `navigationType` it's in `.other` and not in `.linkActivated`, I can't tell it apart from other requests like loading external scripts, the only difference I've noticed is that those have the `sourceFrame` set to `null` and the others don't. For my part, just passing the `sourceFrame` or indicating if it is `null` would be enough for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
