[
https://issues.apache.org/jira/browse/MATH-1426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114362#comment-16114362
]
Gilles commented on MATH-1426:
------------------------------
Thanks for your interest in contributing!
We certainly look forward to having your help with the next release of Commons
Math.
A few nit-picks to make the integration of patches smoother:
* Prefer several small test methods (one for each tested functionality) even if
some boiler-plate code repetition do occur. Having "testInit1()",
"testInit2()", ... is fine (but more meaningful names are preferred if
possible).
* For random generation, please use the classes from [Commons
RNG|http://commons.apache.org/proper/commons-rng/] (cf. examples in other test
classes).
* If using random data, use a fixed seed, unless the behaviour under test has
intrinsic variability (which is not the case here).
* Make test sets small (as long as they can reasonably check the functionality)
to avoid long-running "mvn test"; here I don't think that arrays of length
1048576 were needed.
* Comment out debugging output ("System.out.println")
* Apply a uniform coding style (e.g. there must be a space around operators,
and the tabulation is wrong).
> Add constructor with Double[] argument to DescriptiveStatistics
> ---------------------------------------------------------------
>
> Key: MATH-1426
> URL: https://issues.apache.org/jira/browse/MATH-1426
> Project: Commons Math
> Issue Type: Improvement
> Affects Versions: 4.0
> Reporter: Karl Richter
> Fix For: 4.0
>
> Attachments:
> 0001-fixed-javadoc-of-constructors-in-DescriptiveStatisti.patch,
> 0002-added-constructor-with-Double-argument-to-Descriptiv.patch
>
>
> It'd be nice to have a `Double[]` constructor in `DescriptiveStatistics`.
> The patch is available at https://github.com/apache/commons-math/pull/54 in
> form of a PR as well.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
