[
https://issues.apache.org/jira/browse/LANG-1317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15977688#comment-15977688
]
ASF GitHub Bot commented on LANG-1317:
--------------------------------------
Github user PascalSchumacher commented on the issue:
https://github.com/apache/commons-lang/pull/261
If I'm not mistaken the list returned by `getAllSuperclassesAndInterfaces`
can contain the same interface multiple times if it is implemented by more than
one super class. To prevent this the result should be collected in
`LinkedHashSet` first (similar to
https://github.com/yasserzamani/commons-lang/blob/90e252f571377cac39f5e2a3fc73749f589c24de/src/main/java/org/apache/commons/lang3/ClassUtils.java#L448).
What do you think?
> Add MethodUtils#findAnnotation and extend
> MethodUtils#getMethodsWithAnnotation for non-public, super-class and
> interface methods
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: LANG-1317
> URL: https://issues.apache.org/jira/browse/LANG-1317
> Project: Commons Lang
> Issue Type: Improvement
> Components: lang.reflect.*
> Reporter: Yasser Zamani
> Labels: patch
>
> In order to fix WW-4744 , mainly, I am going to add two functionalities to
> MethodUtils: findAnnotation and findMethodsWithAnnotation.
> findAnnotation will be an extension for Method.getAnnotation that also
> searches interfaces and super classes while caching results with no memory
> leak.
> findMethodsWithAnnotation will be an extension for getMethodsWithAnnotation
> that also supports non public methods, super class and interface methods,
> again, while caching results as above.
> Generally, do you agree with these in a pull request? If so, I will be
> working on it :)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
