[
https://issues.apache.org/jira/browse/COMMONSRDF-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15861534#comment-15861534
]
ASF GitHub Bot commented on COMMONSRDF-47:
------------------------------------------
Github user stain commented on the issue:
https://github.com/apache/commons-rdf/pull/27
OK, so I added them as `Set` - it might be an ordered set (e.g.
`LinkedHashSet`).
I merged `RDFA_XHTML` and `RDFA_HTML` and made them return such a set to
include both `text/html` and `application/xhtml`. Should we redefine
`.equals()` and `hashCode()` to use `uri()` or would that be tricky then for
arbitrary extra RDFSyntax-es? (They could use a `urn:uuid` or something if
they don't know)
> RDFSyntax should be interface, not enum
> ---------------------------------------
>
> Key: COMMONSRDF-47
> URL: https://issues.apache.org/jira/browse/COMMONSRDF-47
> Project: Apache Commons RDF
> Issue Type: Bug
> Components: api
> Affects Versions: 0.2.0
> Reporter: Stian Soiland-Reyes
> Assignee: Stian Soiland-Reyes
> Fix For: 1.0.0
>
>
> [~p_ansell] raises in [pull request
> 25|https://github.com/apache/incubator-commonsrdf/pull/25#discussion_r85231845]
> {quote}
> Using enum for RDFSyntax is a bad idea unless it overrides an interface and
> the interface is used in method signatures instead of the enum. There are
> many other RDFSyntaxes, and enum (without implementing an interface) is only
> suited to cases where the full set are known a priori.
> {quote}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
