[ 
https://issues.apache.org/jira/browse/CRYPTO-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15337770#comment-15337770
 ] 

Sebb commented on CRYPTO-75:
----------------------------

The user source code is not affected regardless of the value of the constant.

However any subsequent change will be binary-incompatible; users will have to 
recompile to ensure that the new constant value is picked up.

Public constants must only be used for values that won't change.

==

However I wonder whether the constant really needs to be public at all - does 
the user need to know the class name of the default?


> ConfigurationKeys#COMMONS_CRYPTO_CIPHER_CLASSES_DEFAULT is not guaranteed 
> constant
> ----------------------------------------------------------------------------------
>
>                 Key: CRYPTO-75
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-75
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
>
> ConfigurationKeys#COMMONS_CRYPTO_CIPHER_CLASSES_DEFAULT contains a 
> fully-qualified class name.
> This is not guaranteed to be constant if the package names ever have to be 
> changed.
> The constant should be changed to an alias that is handled by the runtime 
> code when creating the class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to