[
https://issues.apache.org/jira/browse/CRYPTO-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259706#comment-15259706
]
Dian Fu edited comment on CRYPTO-29 at 4/27/16 7:42 AM:
--------------------------------------------------------
Thanks for reporting this issue. I have create a
[PR|https://github.com/apache/commons-crypto/pull/17] to address this issue.
This PR takes the similar way as the implementation of Cipher in JDK:
# The types of ENCRYPT_MODE and DECRYPT_MODE are primitive integer value. Using
constant value instead of enum is consistent with the implementation in JDK.
# Make sure the values of ENCRYPT_MODE and DECRYPT_MODE are consistent with JDK.
was (Author: dian.fu):
Thanks for reporting this issue. I have create a
[PR|https://github.com/apache/commons-crypto/pull/17] to address this issue.
This PR takes the similar way as the implementation of Cipher in JDK:
# The type of ENCRYPT_MODE and DECRYPT_MODE are primitive integer value.
# Make sure the values of ENCRYPT_MODE and DECRYPT_MODE are consistent with JDK.
> Cypher.ENCRYPT_MODE should be an enum
> -------------------------------------
>
> Key: CRYPTO-29
> URL: https://issues.apache.org/jira/browse/CRYPTO-29
> Project: Commons Crypto
> Issue Type: Bug
> Reporter: Sebb
> Assignee: Dian Fu
>
> Cypher.ENCRYPT_MODE should be an enum
> Or is it supposed to be the same as Openssl.ENCRYPT_MODE?
> In which case, why not use that?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
