[
https://issues.apache.org/jira/browse/NET-583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sebb resolved NET-583.
----------------------
Resolution: Fixed
Fix Version/s: 3.5
Thanks for the bug report and suggested fix.
URL: http://svn.apache.org/viewvc?rev=1739351&view=rev
Log:
NET-583 FTPClient.getReplyString() returns wrong value after connect()
Modified:
commons/proper/net/trunk/src/changes/changes.xml
commons/proper/net/trunk/src/main/java/org/apache/commons/net/ftp/FTPClient.java
> FTPClient.getReplyString() returns wrong value after connect()
> --------------------------------------------------------------
>
> Key: NET-583
> URL: https://issues.apache.org/jira/browse/NET-583
> Project: Commons Net
> Issue Type: Bug
> Components: FTP
> Affects Versions: 3.3
> Reporter: Holger Rehn
> Fix For: 3.5
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> If the FTPClient's automatic server encoding detection is enabled, a FEAT
> command is issued in method _connectAction_() [indirectly via
> hasFeature(String)]. After that, the _replyCode and _replyLines fields are
> stored back to their previous values in _connectAction_(), but the
> _newReplyString flag isn't set to true. Because of that, you will then get
> back the reply to the FEAT command from getReplyString(), instead of the
> server's welcome message. Furthermore, you may get back a reply code that
> doesn't match that reply string. We have encountered a case when we got back
> reply code 220 after FTPClient.connect(), but reply string was "530 Not
> logged in.".
> This error can easily be fixed by adding the following line to FTPClient.java
> around line 944:
> _newReplyString = true;
> Patch:
> ===================================================================
> --- src/org/apache/commons/net/ftp/FTPClient.java
> +++ src/org/apache/commons/net/ftp/FTPClient.java (working copy)
> @@ -941,6 +941,7 @@
> _replyLines.clear();
> _replyLines.addAll(oldReplyLines);
> _replyCode = oldReplyCode;
> + _newReplyString = true;
> }
> }
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
