[
https://issues.apache.org/jira/browse/CONFIGURATION-613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14942967#comment-14942967
]
Maarten Boekhold commented on CONFIGURATION-613:
------------------------------------------------
Hi,
Yes, setTrimmingDisabled(true) fixes my issue. Yet, I wonder if it is not
possible to do better. Bear with me.
Assume MapConfiguration is initialized from a Properties instance. That
Properties instance is presumably loaded from file, which means that
java.util.Properties has already applied its own "trimming rules", eg leading
whitespace *if it is not explicit like with \t* has already been trimmed, and
trailing whitespace has been left alone.
For MapConfiguration there are now 2 situations to consider:
* The property has a single, non-list, value. In this case, I expect the result
of MapConfiguration.getProperty() to be *identical* to
Properties.getProperty(). So, MapConfiguration should *not* do _any_ trimming
_if the property is a single non-list value_.
* The property represents a list. In this case, java.util.Properties has
already applied its own trimming rules, which means that any _non-explicit_
leading whitespace has already been removed. So I expect the first value of the
result of MapConfiguration.getProperty() to leave any _leading_ whitespace _for
the first element_ alone.
I'm not sure yet if this should be the behavior for any MapConfiguration
instance, or only for MapConfiguration instances that have been created from a
Properties object. I think there's an argument there somewhere to apply this
logic as well to the MapConfiguration(Map<String,?> map constructor.
Does this sound reasonable?
> MapConfiguration cannot handle property set to single \t or \n
> --------------------------------------------------------------
>
> Key: CONFIGURATION-613
> URL: https://issues.apache.org/jira/browse/CONFIGURATION-613
> Project: Commons Configuration
> Issue Type: Bug
> Reporter: Maarten Boekhold
>
> See the following test, written in groovy (2.4.4). Open a groovyConsole,
> copy/paste in this code and hit ctrl-Enter to run. You need a working
> internet connection.
> {code}
> @Grab(group='commons-configuration', module='commons-configuration',
> version='1.9')
> import org.apache.commons.configuration.MapConfiguration
> import org.apache.commons.configuration.PropertiesConfiguration
> // groovy dollar-slashy-string syntax, ignores backslash
> // as an escape character so \t remains a literal string
> // backslash + t
> def propsString = $/
> prefix.field1=\t
> prefix.field2=a\tb
> /$
> // Java properties work
> Properties props = new Properties()
> props.load(new StringReader(propsString))
> // OK
> assert props.getProperty('prefix.field1') == '\t'
> // OK
> assert props.getProperty('prefix.field2') == 'a\tb'
> // PropertiesConfiguration works
> PropertiesConfiguration propscfg = new PropertiesConfiguration()
> propscfg.load(new StringReader(propsString))
> // OK
> assert propscfg.getString('prefix.field1') == '\t'
> // OK
> assert propscfg.getProperty('prefix.field2') == 'a\tb'
> // MapConfiguration does not work
> MapConfiguration mapcfg = new MapConfiguration(props)
> // OK
> assert mapcfg.getProperty('prefix.field2') == 'a\tb'
> // FAIL
> // MapConfiguration loses the single tab character
> assert mapcfg.getString('prefix.field1') == '\t'
> {code}
> Output is:
> {noformat}
> Exception thrown
> Assertion failed:
> assert mapcfg.getString('prefix.field1') == '\t'
> | | |
> | "" false
> org.apache.commons.configuration.MapConfiguration@1cd4064c
> at ConsoleScript13.run(ConsoleScript13:35)
> {noformat}
> As you can see, once we've 'converted' the java.util.Properties instance to a
> MapConfiguration, the single \t character is lost. *Embedded* tab characters
> however are retained!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
