[ 
https://issues.apache.org/jira/browse/VFS-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14876345#comment-14876345
 ] 

Simon Legner commented on VFS-497:
----------------------------------

>From the mailing list:

{quote}
 Am Wed, 1 Jul 2015 12:47:56
+0200 (CEST) schrieb wp11158370-michael <[email protected]>:

> Hi Bernd,
>  
> Sorry for bothering you, but I'm not sure if you get a notification
> about pull requests for the Github copy of "commons-vfs".
>  
> I ported the file filters from "commons-io" (inclduing the unit
> tests) and need someone who can merge it into the regular code base:
>  
> https://github.com/apache/commons-vfs/pull/9
>  
> Thank you in advance for looking at it.
>  
> Cheers,
> Michael
>  
{quote}

… and …

{quote}
Bernd Eckenfels Wed, 01 Jul 2015 12:57:05 -0700

Hello Michael,

thanks for the reminder. For some reasons we do not get notifications
for the commons-vfs project on GitHub, but I have seen the Pull Request
in the Jira comment, thats fine to track it.

I somewhat dislike this code duplication and wished there would be a
more generic way to make the filter classes work for both projects. But
since you did all the work and it looks good (including samples and
unit tests), there is nothing stopping us from merging it.

(I have however not the time to check it, I need to do a release first)

Gruss
Bernd
{quote}

> Port file filters from Apache Commons IO to VFS
> -----------------------------------------------
>
>                 Key: VFS-497
>                 URL: https://issues.apache.org/jira/browse/VFS-497
>             Project: Commons VFS
>          Issue Type: Improvement
>            Reporter: Michael Schnell
>              Labels: patch
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> Apache Commons IO has a similar file filter concept as VFS and provides ~20 
> filter implementations. VFS misses such implementations.
> Therefore I ported the IO filters, created & updated unit tests and now I 
> want to contribute that code to VFS.
> The code is currently available on GitHub:
> https://github.com/fuinorg/commons-vfs2-filters



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to