garydgregory commented on PR #768: URL: https://github.com/apache/commons-text/pull/768#issuecomment-5540662970
Hi @lenamonj Nice find, thank you. There are two changes I'd like to see: 1) In `testIsMatchOverloadsAgreeOnTheSameWindow()`, the second case passes `start = 1` with `bufferStart = 2`, outside the documented contract. The method tests the helper’s defensive behavior rather than required API behavior. A valid window that ends before the complete pattern would be a more useful negative case. 2) Add a direct call to the two-argument `isMatch(CharSequence, int)` using the custom matcher. This would explicitly cover the convenience overload that delegates through the corrected method. Explicit expected match lengths would also make the parity assertions easier to interpret. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
