lenamonj opened a new pull request, #633:
URL: https://github.com/apache/commons-csv/pull/633
`CSVPrinter.getRecordCount()` says "this does not include comments or
headers", but the header record the constructor writes is counted: the test
added with the method in CSV-313 asserts a count of 1 right after the header
("The header is the first record"). A caller reading the Javadoc gets one fewer
than the printer reports whenever the format carries a header.
Javadoc only. It now says the constructor's header record is counted and
that comments and `printHeaders(ResultSet)` are not.
Verified with the default `mvn` goal (checkstyle, PMD, SpotBugs, japicmp,
RAT).
Found by an automated review loop I run; the change was reviewed and
verified by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
