ppkarwasz commented on code in PR #82:
URL: https://github.com/apache/commons-secure-xml/pull/82#discussion_r3908465982
##########
pom.xml:
##########
@@ -75,14 +75,19 @@ limitations under the License.
<commons.xerces.version>2.12.2</commons.xerces.version>
<!-- Test-only: computes each secure class' shade closure, mirroring
maven-shade minimizeJar, for ShadingFootprintTest. -->
<commons.jdependency.version>2.16</commons.jdependency.version>
- <!-- jacoco-maven-plugin: Should only get better -->
+ <!--
+ jacoco-maven-plugin: Should only get better.
+
+ A single `mvn -Pjacoco clean verify` run covers less than the project as
a whole does.
+ These minima need to pass on all JDK versions, in particular JDK 8 and
JDK 21.
+ -->
<commons.jacoco.haltOnFailure>true</commons.jacoco.haltOnFailure>
- <commons.jacoco.classRatio>0.97</commons.jacoco.classRatio>
- <commons.jacoco.instructionRatio>0.97</commons.jacoco.instructionRatio>
- <commons.jacoco.methodRatio>0.99</commons.jacoco.methodRatio>
- <commons.jacoco.branchRatio>0.91</commons.jacoco.branchRatio>
- <commons.jacoco.lineRatio>0.96</commons.jacoco.lineRatio>
- <commons.jacoco.complexityRatio>0.96</commons.jacoco.complexityRatio>
+ <commons.jacoco.classRatio>0.96</commons.jacoco.classRatio>
+ <commons.jacoco.instructionRatio>0.93</commons.jacoco.instructionRatio>
+ <commons.jacoco.methodRatio>0.95</commons.jacoco.methodRatio>
+ <commons.jacoco.branchRatio>0.87</commons.jacoco.branchRatio>
+ <commons.jacoco.lineRatio>0.93</commons.jacoco.lineRatio>
+ <commons.jacoco.complexityRatio>0.92</commons.jacoco.complexityRatio>
Review Comment:
> How is it that running more tests lowers the test coverage percentages?
Sorry, now I understand the question.
The values were lowered, so that a **single** build on **any** JDK passes
them. This way if you run:
```bash
mvn -Pjacoco clean verify
```
the build passes and you don't need to run multiple `-Pjacoco test` on
multiple JDKs, before you can run `verify`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
