NikRom5531 opened a new pull request, #409: URL: https://github.com/apache/commons-jexl/pull/409
### Summary / Why Fixing bug JEXL-411 (https://issues.apache.org/jira/browse/JEXL-411): JEXL could not parse a floating point literal with an omitted leading zero (e.g. ".1"), so "(1+0.1)*2" evaluated to 2.2 while "(1+.1)*2" raised a parsing error, although ".1" is valid in Java. ### How A leading-dot number is tokenized as "DOT DOT_IDENTIFIER", which is identical to the postfix index access "x.3" and cannot be told apart at the lexer level. The literal is therefore recognized in the parser, in operand position. `FloatLiteral()` in `Parser.jjt` now also accepts ".<digits>" (only all-digit `DOT_IDENTIFIER` images, checked via a new `isAllDigits` guard) and rebuilds the value as "." + image before handing it to `NumberParser`. Dot-based index/property access is parsed first by `MemberAccess`/`IdentifierAccess` and left untouched. ### Tests `ArithmeticTest#testLeadingDotFloatLiteral`: - "(1+.1)*2" == 2.2 (JEXL-411 reproduction) - "(1+0.1)*2" == 2.2 (regression) - ".1" == 0.1, "-.1" == -0.1, ".5 + .5" == 1.0, ".55" == 0.55 - unary/compound: "-.1+.2" == 0.1, ".1+-.2" == -0.1, ".5 - -.9" == 1.4 - "array.1" still resolves to index access (regression) - The test fails on the previous grammar and passes on this one. ### Verification - `mvn` (incl. apache-rat license check): BUILD SUCCESS - `mvn test`: 1164 tests, 0 failures, 0 errors ### Notes - The JIRA account was read-only, so a PR link could not be added to the ticket; the issue is referenced via the key in the branch, commits and this description. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [x] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
