rootvector2 commented on PR #630: URL: https://github.com/apache/commons-csv/pull/630#issuecomment-5239330121
Right, the temp file test showed nothing: deleting an open file succeeds on POSIX, so the only observable effect was the throw. Reworked the PR into just a better `Path` test on top of your refactoring. `Files.newInputStream` dispatches through `path.getFileSystem().provider()`, so mocking that chain lets the test hand `parse(Path)` a close-recording stream, same shape as the URL test. It fails on master with the close in `parse(IOSupplier)` removed and passes as is, on any platform. Full default `mvn` build is green. Thanks for bringing the fix in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
