garydgregory commented on code in PR #430:
URL: https://github.com/apache/commons-validator/pull/430#discussion_r3665052796
##########
src/test/java/org/apache/commons/validator/routines/CurrencyValidatorTest.java:
##########
@@ -176,6 +179,21 @@ void testPattern() {
assertFalse(validator.isValid(ukPound + "1,234.567", pattern,
Locale.US), "invalid symbol");
}
+ /**
+ * Test currency values with a pattern that suffixes the symbol, which
locales such as de-DE separate from the number with a non-breaking space. The
symbol
Review Comment:
The comment make a claim about DE and the code about US. Add a test for
each, or parameterize the current test for both, better yet, for all known
currency symbols.
##########
src/test/java/org/apache/commons/validator/routines/PercentValidatorTest.java:
##########
@@ -100,6 +105,21 @@ void testNumberRangeExactBound() {
assertFalse(instance.minValue(new BigDecimal("5"), new
BigDecimal("5.5")));
}
+ /**
+ * Test percentage values with a pattern that suffixes the symbol, which
locales such as fr-FR separate from the number with a non-breaking space. The
Review Comment:
The comment make a claim about FR and the code about US. Add a test for
each, or parameterize the current test for both, better yet, for all known
currency symbols.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
