Copilot commented on code in PR #626:
URL: https://github.com/apache/commons-csv/pull/626#discussion_r3637889126
##########
src/main/java/org/apache/commons/csv/CSVParser.java:
##########
@@ -806,8 +806,10 @@ private String handleNull(final String input) {
final String nullString = format.getNullString();
final boolean strictQuoteMode = isStrictQuoteMode();
if (input.equals(nullString)) {
+ // An escaped value is the null string itself, not the null
marker: printing null writes the null string
+ // verbatim, so "\\N" for nullString "\N" can only have come from
a value that really is "\N".
Review Comment:
The new comment suggests that printing null always writes the null marker
"verbatim", but `CSVFormat#print` can emit a *quoted* null marker when
`QuoteMode.ALL` is configured (see `CSVFormat#print`: it uses
`quotedNullString`). Consider rewording to avoid implying it is always
unquoted/verbatim.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
