sahvx655-wq commented on PR #429: URL: https://github.com/apache/commons-validator/pull/429#issuecomment-5056645685
Those five are all general category Cf, so the FORMAT check merged in #420 already rejects them; I re-checked the categories to be sure (00AD, 200B..200D and FEFF all report Character.FORMAT) and testIDNFormatCodePoints pins them. 200C was the one from your list without an explicit assertion, so I've pushed a commit adding it and the class is green (22 tests). This PR is about the remainder of the RFC 3454 Table B.1 set that is not Cf: U+034F, U+1806, U+180B..U+180D and U+FE00..U+FE0F report as Mn/Pd, so the getType check waves them through while IDN.toASCII still deletes them during nameprep, which is how exa͏mple.com was converting to and validating as example.com. The isNameprepMappedToNothing guard covers exactly that leftover set; without it the invisible-character homograph hole from #420 stays half open for those code points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
