sahvx655-wq opened a new pull request, #428: URL: https://github.com/apache/commons-validator/pull/428
- [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. `EmailValidator.isValidDomain` hands the contents of a bracketed host to `InetAddressValidator.isValid`, which accepts an IPv4 or an IPv6 address without distinguishing them. RFC 5321 section 4.1.3 tags an IPv6 address literal with `IPv6:` and leaves an IPv4 literal untagged, so the current code is wrong at both ends: it accepts a bare `user@[::1]`, which no conformant parser should, and rejects the correctly tagged `user@[IPv6:::1]` because the `IPv6:` prefix reaches `InetAddressValidator` as part of the address and the parse fails. I came across it while checking why a valid IPv6 literal was being turned away when the malformed bare form validated. The fix matches the `IPv6:` tag on the bracket contents, case insensitively since it is ABNF-literal text, and validates the remainder as IPv6; an untagged literal is validated as IPv4 only. Keeping the split in `isValidDomain` leaves the IPv4-versus-IPv6 rule in the one place that parses the bracketed host, and the deprecated `validator.EmailValidator` inherits it because its `isValid` delegates here. Left unfixed, an allow-list built on this treats a bare loopback or link-local literal that no conformant MTA routes as valid while refusing the RFC form. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
