kali834x commented on PR #788: URL: https://github.com/apache/commons-compress/pull/788#issuecomment-5033150082
decodeBandInt is shared by all the band reads (counts, flags, signed deltas), so it doesn't know which pool, if any, the decoded values will index into, and most of its callers have no bound to check against. The earliest point where the indices and the pool size are both in hand is getReferences, right after the decode, which is where parseReferences already does the same check. These call sites can't just switch to parseReferences because they keep the raw ints around (getCpDescriptorNameInts and friends). Happy to add a bounded overload for the reference bands instead if you'd prefer failing inside the decode. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
