raboof commented on PR #714:
URL: https://github.com/apache/commons-parent/pull/714#issuecomment-5032488967
> Hi @raboof It doesn't matter. All builds currently allow for the build
system to be the same as the target platform, in this case Java 8. Since we
still want to play it safe and make sure we don't introduce any kind of
incompatibility like the NIO Buffer mess with co-variant types.
I'm aware of that Buffer issue, and indeed building on Java8 is a workaround
for it. However, looking at the last few votes (both by you and Mark), AFAICT
in practice we're often not building releases with Java 8 at all.
This is OK because the parent pom already has the java-9-up profile setting
`<maven.compiler.release>${commons.compiler.release}</maven.compiler.release>`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
