farkhalit opened a new pull request, #433: URL: https://github.com/apache/commons-cli/pull/433
`DefaultParser.handleProperties` calls `processValue` on the `Option` instance owned by the caller's `Options` rather than on a copy, so a value that arrives through the defaults `Properties` is written into the shared `Option` and stays there after the parse. Reuse that same `Options` for a second parse and the `isValuesEmpty` guard silently serves the first parse's value instead of the second one's, the value remains readable through `options.getOption(...)`, and two threads parsing at once write the same values list. `Parser.processProperties` has the same write-through and also puts the shared `Option` on the `CommandLine`, so a later parse rewrites what an earlier `CommandLine` returns. Both property paths now clone before storing the value, which is what the argv paths already do in `handleOption` and `processArgs`. The new test in `AbstractParserTestCase` fails for `DefaultParser`, `BasicParser`, `GnuParser` and `PosixParser` without the change. - [x] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [x] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [x] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
