griffinjm commented on code in PR #672:
URL:
https://github.com/apache/commons-collections/pull/672#discussion_r2962722428
##########
src/test/java/org/apache/commons/collections4/trie/PatriciaTrieTest.java:
##########
@@ -437,6 +437,160 @@ void testPrefixMapSizes2() {
assertTrue(trie.prefixMap(prefixString).containsKey(longerString));
}
+ @Test
Review Comment:
Added these simple tests to verify continued correctness of the modified
methods.
I could also add a threaded test which verifies there is no CME when one
thread is iterating and another is creating a new sub/tail/head/prefix map
view, but it's not guaranteed to result in a CME depending on timing. From my
own local testing using a constantly iterating thread and a second thread which
constantly creates new map views it fixes the issue, no CMEs on the new branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
