ShreyanshRaj22 opened a new pull request, #1615: URL: https://github.com/apache/commons-lang/pull/1615
Description This PR addresses LANG-1696 by improving the behavior of `EqualsBuilder.reflectionEquals` when comparing `Collection` and `Map` instances. https://issues.apache.org/jira/browse/LANG-1696 Instead of performing reflective field comparison on these types, the implementation now delegates directly to their `equals` methods. Since `Collection` and `Map` already define well-established equality semantics based on their contents, this produces more consistent and expected results when comparing different implementations containing the same elements. Changes - Detect `Collection` and `Map` instances in `reflectionEquals` and delegate comparison to their `equals` implementations. - Added a unit test verifying equality between different collection implementations (e.g., `HashSet` and `Collections.emptySet()`). Compatibility As noted in LANG-1696, this may change equality outcomes in cases where reflective comparison previously produced different results, but the new behavior aligns with the standard semantics of the Java Collections Framework. <!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor license agreements. See the NOTICE file distributed with this work for additional information regarding copyright ownership. The ASF licenses this file to you under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at https://www.apache.org/licenses/LICENSE-2.0 Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. --> Thanks for your contribution to [Apache Commons](https://commons.apache.org/)! Your help is appreciated! Before you push a pull request, review this list: - [ ] Read the [contribution guidelines](CONTRIBUTING.md) for this project. - [ ] Read the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) if you use Artificial Intelligence (AI). - [ ] I used AI to create any part of, or all of, this pull request. Which AI tool was used to create this pull request, and to what extent did it contribute? - [ ] Run a successful build using the default [Maven](https://maven.apache.org/) goal with `mvn`; that's `mvn` on the command line by itself. - [ ] Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied. This may not always be possible, but it is a best practice. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Each commit in the pull request should have a meaningful subject line and body. Note that a maintainer may squash commits during the merge process. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
