bsanchezb commented on PR #419: URL: https://github.com/apache/commons-codec/pull/419#issuecomment-3699867334
Hi @garydgregory , Thank you for the thoughtful review. I added changes according to your comments. Regarding the > I am concerned we are increasing the public footprint in this class by a lot. For example, I do not see a public use case for: > > isBase64Standard(byte) > isBase64Url(byte) > > If you disagree, please explain. The idea is that we should YAGNI the API here. I do not have a strong opinion on this, but I was trying to apply the same design pattern used for the `Base64#isBase64` methods, which also includes the `#isBase64(final byte[] arrayOctet)` method, so people have a familiar architecture if when decide to switch to one of the new implementations. I will leave it up to you to decide. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
