ecki commented on code in PR #1392:
URL: https://github.com/apache/commons-lang/pull/1392#discussion_r2365241455
##########
src/test/java/org/apache/commons/lang3/StringUtilsTest.java:
##########
@@ -3089,6 +3089,31 @@ void testTruncate_StringIntInt() {
assertEquals("", StringUtils.truncate("abcdefghijklmno",
Integer.MAX_VALUE, Integer.MAX_VALUE));
}
+ @Test
+ void testTruncateToByteLength() {
Review Comment:
Maybe habe one method testing the various null cases (more than at the
moment) one for the usual single byte ascii cases one for bmp Tests and then
one for Graphen cases and one for Dynamic. I would also avoid Emoji literals in
source
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]