basil commented on code in PR #367:
URL: https://github.com/apache/commons-beanutils/pull/367#discussion_r2270720998
##########
src/main/java/org/apache/commons/beanutils2/converters/BooleanConverter.java:
##########
@@ -67,6 +56,11 @@ private static String[] copyStrings(final String[] src) {
*/
private String[] falseStrings = { "false", "no", "n", "off", "0" };
+ /**
+ * The locale to use for string comparisons.
+ */
+ private Locale locale = Locale.getDefault();
Review Comment:
> I would either use `Locale.ROOT` as default value, since the default
strings are in English, or force the user to pass the Locale in the constructor.
I have done the former in commit cfba84fa.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
