ppkarwasz commented on code in PR #1385:
URL: https://github.com/apache/commons-lang/pull/1385#discussion_r2094456368
##########
pom.xml:
##########
@@ -462,6 +463,32 @@
<!-- LANG-1667: allow tests to access private fields/methods of
java.base/java.util such as ArrayList via reflection -->
<argLine>-Xmx512m --add-opens java.base/java.lang.reflect=ALL-UNNAMED
--add-opens java.base/java.lang=ALL-UNNAMED --add-opens
java.base/java.util=ALL-UNNAMED --add-opens java.base/java.time=ALL-UNNAMED
--add-opens java.base/java.time.chrono=ALL-UNNAMED</argLine>
</properties>
+ <build>
+ <plugins>
+ <!--
+ ~ Modifies the inherited Moditect configuration to add `java.sql`
as `static` (optional) dependency.
+ -->
+ <plugin>
+ <groupId>org.moditect</groupId>
+ <artifactId>moditect-maven-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>add-module-infos</id>
+ <configuration>
+ <module>
+ <moduleInfo>
+ <requires>
+ static java.sql;
+ *;
+ </requires>
+ </moduleInfo>
+ </module>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
Review Comment:
I attempted to update the inherited Moditect Maven Plugin configuration to
include the following directive in the generated module descriptor:
```java
requires static java.sql;
```
However, due to moditect/moditect#262, this change currently has no effect.
@garydgregory, should we keep the directive in place in anticipation of the
issue being fixed, or remove it for now and reintroduce it once the plugin
supports it correctly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
