garydgregory commented on code in PR #1379: URL: https://github.com/apache/commons-lang/pull/1379#discussion_r2085058140
########## src/main/java/org/apache/commons/lang3/RandomStringUtils.java: ########## @@ -97,6 +97,7 @@ public class RandomStringUtils { private static final int ASCII_9 = '9'; private static final int ASCII_A = 'A'; private static final int ASCII_z = 'z'; + private static final int MAX_CACHE_SIZE = 60_000_000; Review Comment: This value seems arbitrary. The constant should have a Javadoc even if it only says this is a completely arbitrary choice or serves some defined use case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org