garydgregory commented on PR #328:
URL: https://github.com/apache/commons-rdf/pull/328#issuecomment-2870286519
Hello @naturzukunft
I've taken a look again and here's what I propose:
- Since this is not 1.0 yet, we can change the behavior and APIs, which here
feels like a bug anyway.
- Since `GraphLike` is not a `Collection`, it does not need to define a
`parallelStream()` API.
- Change `stream()` implementations to return a plain (IOW sequential)
stream.
- If a call site wants a parallel stream, it should call
`stream().parallel()` per:
- `java.util.stream.BaseStream.parallel()`
- `java.util.stream.BaseStream.sequential()`
- The above avoids increasing the public API surface with seemingly
redundant APIs.
All the above should be OK unless there's something in the domain model that
requires implementations to be parallel, so you see such a requirement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
