SethFalco commented on PR #49: URL: https://github.com/apache/commons-beanutils/pull/49#issuecomment-2823556581
I've just rebased with `master`, but have also made a few changes this time: 1. I removed my modifications to `CharacterConverter` which added support for hex strings via a `0x` prefix. I can add this back in upon request. In 2025, I don't see any reason to bundle this logic when file/string encoding should just be configured properly for projects/infra. Retrospecting on the past, even in the instance I referred to in the original issue where symbols like `£` would break, we could've easily changed the file encoding to UTF-8, I just wasn't aware of why certain characters were breaking at the time. 2. My PR no longer migrates test cases to JUnit 5 as that has already been done in `master`. (I did however keep the changes that that made `CharacterConverterTest` use the same variable between test cases.) That means the scope of the PR is: * Add support for the `Instant` type. * Add an explicit error for empty strings for `CharacterConverter`. * Migrate some instances of `String.valueOf` to the `toString(value)` helper. * Expand on the logic for the `EnumConverter` to support fully qualified Enum constants. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
