[
https://issues.apache.org/jira/browse/MATH-1671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17940776#comment-17940776
]
Alex Herbert commented on MATH-1671:
------------------------------------
I have updated the PR to fix some coverage gaps in the new code (in new class
files). The CodeCov report also identifies missing coverage for code that was
changed to call Commons Statistics. This code previously had no coverage and I
have not added tests for these. For code outside of the stat package this is
simply due to a partial coverage test suit. For some of the code inside the
stat package I would prefer to remove it.
For example there are many implementations of hashCode and equals for classes.
I do not know why there are implemented. The statistics classes are not likely
to be used for keys in a map. Implementation of equals is to check if two
statistics are the same. Is this necessary for VectorialCovariance,
VectorialMean, SemiVariance, or summary statistics?
There are tests for hashcode/equals for the summary statistic classes. There
are tests in StorelessUnivariateStatisticAbstractTest for the single statistics
but since VectorialCovariance, VectorialMean, SemiVariance do not implement the
tested interface their methods are not checked.
The SemiVariance has many overridden evaluate methods in the class which all
call a single implementation. The overrides provide a way to change the
direction and population variance arguments which default to those set by the
class instance properties. Since not all of these methods are not tested I
would remove them as redundant.
> Reuse "Commons Statistics" (descriptive)
> ----------------------------------------
>
> Key: MATH-1671
> URL: https://issues.apache.org/jira/browse/MATH-1671
> Project: Commons Math
> Issue Type: Sub-task
> Components: legacy
> Affects Versions: 4.0-beta1
> Reporter: Gilles Sadowski
> Priority: Major
> Labels: pull-request-available, refactor
> Fix For: 4.0-beta2
>
>
> Reuse functionality in module
> [{{descriptive}}|https://commons.apache.org/proper/commons-statistics/commons-statistics-docs/apidocs/org/apache/commons/statistics/descriptive/package-summary.html].
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
