jfclere commented on code in PR #238: URL: https://github.com/apache/commons-daemon/pull/238#discussion_r1998297223
########## src/native/windows/apps/prunsrv/prunsrv.c: ########## @@ -1269,7 +1277,7 @@ static DWORD WINAPI serviceStop(LPVOID lpParameter) } else { if (lstrcmpA(_jni_sclass, "java/lang/System") == 0) { - reportServiceStatus(SERVICE_STOP_PENDING, NO_ERROR, 20 * 1000); + reportServiceStatus(SERVICE_STOP_PENDING, NO_ERROR, ONE_MINUTE); Review Comment: That is a hint procrun gives to the windows service manager, it needs to be bigger than the time procrun needs to stop the service, otherwise an error is reported. But yes it could depend on the timeout. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org