rajucomp commented on PR #385: URL: https://github.com/apache/commons-pool/pull/385#issuecomment-2631532943
Hi [ggregory](https://issues.apache.org/jira/secure/ViewProfile.jspa?name=ggregory). Hope you are well. I really thought about your comment last year to focus on bug fixes. I have tried my best. I have created a PR at https://github.com/apache/commons-pool/pull/385. 1. The PR adds a test to demonstrate that the value of getMaxActive can be a negative number. 2. The PR also proposes a solution to fix this issue. During my debugging, I found that when the returned objects were being added back to the set of the idle objects, there was a possibility where they could have been invalidated by another thread leading to invalid objects being added back to the pool which is not desirable. I am eager to know you critical thoughts on this. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
