garydgregory commented on PR #629:
URL: https://github.com/apache/commons-io/pull/629#issuecomment-2598500937

   -1:
   - The current PR is completely wrong on Windows:
     - The PR returns part of the stream name or type, NOT the file extension! 
     - The format is `<filename>:<stream name>:<stream type>`
     - The file name extension for `"foo.exe:bar.txt"` is `"exe"`, not `"txt"`.
   - The test needs an explicit check for `"C:file.txt"` since this is the 
common example given in the Jira and here.
   - The needs tests for each combination of `<filename>:<stream name>:<stream 
type>`
   - Also, with and without driver letters.
   
   Tangent: Note that we also have the class FileSystems for OS-specific 
implementations but it does not have this kind of API.
   
   See [NTFS Streams 
](https://learn.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/c54dec26-1551-4d3a-a0ea-4fa40f848eb3)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to