jkbkupczyk commented on code in PR #318:
URL: https://github.com/apache/commons-net/pull/318#discussion_r1913876378
##########
src/main/java/org/apache/commons/net/tftp/TFTPRequestPacket.java:
##########
@@ -56,6 +59,9 @@ public abstract class TFTPRequestPacket extends TFTPPacket {
/** The file name of the request. */
private final String fileName;
+ /** The option values */
+ private Map<String, String> options = new HashMap<>();
Review Comment:
I think `options` can be `final`.
##########
src/main/java/org/apache/commons/net/tftp/TFTPRequestPacket.java:
##########
@@ -56,6 +59,9 @@ public abstract class TFTPRequestPacket extends TFTPPacket {
/** The file name of the request. */
private final String fileName;
+ /** The option values */
+ private Map<String, String> options = new HashMap<>();
Review Comment:
According to _rfc2347_. A new error code with value `8` is defined to
indicate that a transfer should be terminated due to option negotiation. I
think you can safely add new err code to `TFTPErrorPacket` ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@commons.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
