[ https://issues.apache.org/jira/browse/MATH-1650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909344#comment-17909344 ]
Michael Scholz commented on MATH-1650: -------------------------------------- [^2025-01-02_ClampedSplineInterpolator.patch] now contains: * Different approach by not overloading {{interpolate()}} anymore but providing two separate functions – a regular 2-parameter and another 4-parameter function for specifying the clamped spline's boundary conditions (slopes/derivatives). This should avoid blowing up the API. * Thorough test package. How to proceed efficiently in order to close this issue and also to close our former [GitHub pull request #83|https://github.com/apache/commons-math/pull/83]? > Add clamped spline interpolation > -------------------------------- > > Key: MATH-1650 > URL: https://issues.apache.org/jira/browse/MATH-1650 > Project: Commons Math > Issue Type: New Feature > Affects Versions: 4.X > Reporter: Michael Scholz > Priority: Minor > Labels: Polynomials, interpolation, spline > Attachments: 2022-10-05_ClampedSplineInterpolator.patch, > 2025-01-02_ClampedSplineInterpolator.patch > > > We would like to contribute a new _clamped_ spline interpolation function in > addition to the already available unclamped spline function. Our new > {{ClampedSplineInterpolator}} is based on the same textbook as the original > {{{}SplineInterpolator{}}}. The clamped spline offers additional > parameterisation of starting and ending slopes (1st derivatives) as boundary > conditions in order to provide more flexibility in spline creation. > In this patch we follow the approach of subclassing the original > {{SplineInterpolator}} and simply overloading it's {{interpolate()}} function > by these two additional parameters. Is this an acceptable way or does the > community recommend a different design approach? > After clarifying the basic implementation approach we could also supply > necessary tests etc. and finally contribute everything via ordinary GitHub > pull request. > Refer to our post on the dev mailing list: > https://lists.apache.org/thread/34qnx4tgjbyv345lgmd57g0bnlnwdzc8 > -- This message was sent by Atlassian Jira (v8.20.10#820010)