rajucomp commented on PR #374:
URL: https://github.com/apache/commons-pool/pull/374#issuecomment-2551454214

   > Hello @rajucomp I am sorry but this PR is too way big and messy to review. 
If this is about generics, then ONLY make it about generics please. The PR adds 
Mockito which is not needed to test generics IMO. There are also cosmetic 
changes it seems. A PR should be focused. I'd rather see effort in fixing bugs 
than picking up an 11 year old Jira ticket.
   
   The way the tests are currently being tested is not efficient. We use a 
class called `MethodCall` to verify function calls which does not seem the 
right way. Changing the test to use generics will require changes in the 
`MethodCall` class as well. I could try to shorten the PR to include only 
minimal generic changes. 
   
   Later, I can raise a PR that includes Mockito changes.  Does that make sense 
?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to