[ 
https://issues.apache.org/jira/browse/POOL-238?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17906748#comment-17906748
 ] 

Raju Gupta commented on POOL-238:
---------------------------------

[~Soughman96] [~ggregory] I have created a draft pull request for you to review 
at 
[https://github.com/apache/commons-pool/pull/374|https://github.com/apache/commons-pool/pull/374.]
  . There is some finishing touches still required but I want to know if this 
is something you would consider worth reviewing, Let me know your thoughts on 
this.

> Improve test generics
> ---------------------
>
>                 Key: POOL-238
>                 URL: https://issues.apache.org/jira/browse/POOL-238
>             Project: Commons Pool
>          Issue Type: Test
>    Affects Versions: 1.6, 2.0
>            Reporter: Sebb
>            Priority: Minor
>             Fix For: 2.12.1
>
>
> From the dev mailing list:
> {noformat}
> > --- 
> > commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
> >  (original)
> > +++ 
> > commons/proper/pool/trunk/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
> >  Mon Oct 14 20:42:03 2013
> > @@ -60,10 +60,10 @@ public class TestGenericKeyedObjectPool
> >      protected KeyedObjectPool<Object,Object> makeEmptyPool(int 
> > mincapacity) {
> >
> >          KeyedPooledObjectFactory<Object,Object> factory =
> > -                new KeyedPooledObjectFactory<Object,Object>()  {
> > +                new BaseKeyedPooledObjectFactory<Object,Object>()  {
> One day, if someone wants to do a public service and seize a great
> opportunity to jump into [pool], s/he will fix the cheezy <Object,
> Object> setup in these tests and actually generify the test
> factories here. :)
> Phil
> {noformat}
> Created issue so it's not forgotten



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to