[
https://issues.apache.org/jira/browse/CSV-313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888266#comment-17888266
]
Gary D. Gregory commented on CSV-313:
-------------------------------------
Hello [~unitedmarsupials]
{quote}I don't see this. Of course, I did mvn test before submitting the patch,
and it succeeds with both JDK8 and JDK17:
{quote}
I wrote "mvn" in my reply as opposed to "mvn test" for a reason: Running "mvn"
causes Maven to execute the default goal, which in all Commons components does
a lot more than "mvn test".
In this case, running "mvn" is equivalent to "clean verify apache-rat:check
japicmp:cmp spotbugs:check pmd:check pmd:cpd-check javadoc:javadoc
checkstyle:check"
You can find this documented on [https://github.com/apache/commons-csv] under
"Contributing"
{quote}Then, perhaps, an attempt to submit a patch should be directing people
to GitHub automatically?
{quote}
Please remember that Apache is a volunteer-led organization, not a corporation
with the time and resources to provide a perfect development infrastructure ;)
GitHub is great but we started with Jira and it is simpler to keep tickets here
than some here, some there. Who knows what will happen in the future?
{quote}I was hoping, someone else would help with this – my home machine has no
database-servers within reach, so obtaining a meaningful ResultSet would be
hard.
{quote}
If you had looked at the unit test, you would have discovered that we use an
in-memory database to validate that the code works. Tests are fundamental, have
a google at test-driven development (TDD). ;) You are expected to prove that
the code you write works, not just throw it over the wall and expect someone
else to complete the task :(
{quote}But the idea is simple, even if my patch is imperfect, it should not
take a current team-member long to implement it following the team's practices,
customs, and traditions.
{quote}
Your assumptions are incorrect. You are asking someone else to take time away
from their existing responsibilities.
HTH
> No way to obtain the number of rows written by CSVPrinter's printRecords()
> --------------------------------------------------------------------------
>
> Key: CSV-313
> URL: https://issues.apache.org/jira/browse/CSV-313
> Project: Commons CSV
> Issue Type: Improvement
> Components: Printer
> Reporter: Mikhail T.
> Priority: Minor
> Labels: easyfix
> Attachments: printRecords.patch.txt
>
>
> The {{printRecords(ResultSet)}} variant is very convenient for outputting
> _all_ of a query's results in a single line of code.
> Unfortunately, this provides no way to obtain the number of records printed.
> See [this StackOverflow
> question|https://stackoverflow.com/questions/79071049/], for example.
> A forward-only result-set is "done" after the method returns...
> The simplest way to address this shortcoming would be for the
> {{printRecords()}} to start returning a {{long}} (for lack of {{{}size_t{}}})
> instead of {{{}void{}}}, indicating the number of records printed.
> This seems like an easy fix, for certainly the number of output rows is
> _known_ inside the method...
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
