garydgregory commented on PR #541: URL: https://github.com/apache/commons-vfs/pull/541#issuecomment-2135203700
Hello @japplis Thank you for your PR. This bug fix and performance improvements should be performed in separate PRs to get the bug fix in (with a matching test that fails without the fix) regardless of the performance work. A performance claim should be backed up by a JMH benchmark so that a maintained can duplicate the claim. For examples of how to do this, please see Commons BCEL, Crypto, CSV, Email, IO, Lang, and Text. TY! Gary -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
