speters33w commented on PR #552: URL: https://github.com/apache/commons-text/pull/552#issuecomment-2131888601
I haven't downloaded this PR yet to take a good look at it yet. Probably Monday. I'll pull it and run a few aggressive tests. As far as conventions for camelCase, PascalCase, etc. there is a pretty good list I developed for a raw edit of CaseUtils in [PR 528](https://github.com/apache/commons-text/pull/528) of conventions, not opinions on what they should or should not be. camelCase should always start in lower case, PascalCase should always start with upper case if converting to ASCII, or title case (as defined by Unicode) if retaining UTF encodings. My PR tries to convert everything to lower ASCII that can be converted. dot case and phrase case are not included in my PR but are easily obtained through delimiters. @theshoesiner took a completely different approach in [PR 450](https://github.com/apache/commons-text/pull/450) that retains Unicode characters instead of converting to lower ASCII Latin. I'd thought of merging our two PRs and seeing if we could make something of it with an option to retain Unicode or convert to lower ASCII. I haven't looked at yours yet, but I did write some good JUnit tests I can use on it to see how she handles. As I said, I'll give that a shot sometime Monday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
