[ 
https://issues.apache.org/jira/browse/COMPRESS-667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17822987#comment-17822987
 ] 

Daniel Lowe commented on COMPRESS-667:
--------------------------------------

{quote}It does, look for all callers of {{ZipFile.builder()}} and you'll find 
plenty of tests using different input types.
{quote}
Sorry my mistake, apologies for the invalid issue!
(I originally had a declared dependency on an older version of Commons-IO which 
was overriding the version that Commons-Compress required and meant that 
{color:#000000}{color:#000000}AbstractStreamBuilder {color}{color}wasn't 
available on the classpath, hence the IDE was only showing the methods directly 
available from the Builder class rather than the inherited methods)

> ZipFile Builder lacks convenience constructors for File/Path
> ------------------------------------------------------------
>
>                 Key: COMPRESS-667
>                 URL: https://issues.apache.org/jira/browse/COMPRESS-667
>             Project: Commons Compress
>          Issue Type: Improvement
>    Affects Versions: 1.26.0
>            Reporter: Daniel Lowe
>            Priority: Major
>
> The current Builder implementation appears to not have convenience methods 
> for the most common construction scenarios e.g. construction from a File or 
> Path.
> As 
> {color:#000000}{color:#000000}ZipFile.{color}{color:#000000}builder{color}{color:#000000}().get()
>  {color}{color}isn't valid, personally I think the Builder constructor itself 
> should require a 
> {color:#000000}{color:#000000}SeekableByteChannel/{color}{color}File/Path{color:#000000}{color:#000000}
>  {color}{color}
> I tend to agree with Elliotte's comments 
> ([https://lists.apache.org/thread/5vtbbs18d4rntn8tpnpsvo0g9h6svc30),] and 
> would also see de-deprecating the one argument  constructors as a valid 
> solution



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to