garydgregory commented on PR #229: URL: https://github.com/apache/commons-codec/pull/229#issuecomment-1893044860
> Thanks for the explanation! Since you pointed out that `32 * 32` is too small, we wonder what do you think about changing the byte array size to `1024 * 2 or 3` instead of `1024 * 1024`? just want to know the reason behind `1024 * 1024`. @TestImprove I think you're asking a question that was already answered above by @aherbert > > Also, we are curious why some tests in `MessageDigestAlgorithmsTest` have the same statement twice. For example in the `testDigestByteArray()` test method, the statement `assertArrayEquals(digestTestData(messageDigestAlgorithm), DigestUtils.digest(DigestUtils.getDigest(messageDigestAlgorithm), getTestData()));` is written twice. Without taking the time to analyze this example, I can say there are many ways to test code, one of which is testing for idempotency and side effects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
