garydgregory commented on code in PR #204:
URL: https://github.com/apache/commons-net/pull/204#discussion_r1446780777
##########
src/main/java/org/apache/commons/net/ftp/FTPSClient.java:
##########
@@ -1052,5 +1052,73 @@ protected void sslNegotiation() throws IOException {
}
}
+ /**
+ * Gets the security mode. (True - Implicit Mode / False - Explicit Mode)
+ * @since 3.11.0
+ */
+ protected boolean isImplicit() {
+ return isImplicit;
+ }
+
+ /**
+ * Gets the secure socket protocol to be used, e.g. SSL/TLS.
+ * @since 3.11.0
+ */
+ protected String getProtocol() {
+ return protocol;
+ }
+
+ /**
+ * Gets whether a new SSL session may be established by this socket.
Default true
+ * @since 3.11.0
+ */
+ protected boolean isCreation() {
+ return isCreation;
+ }
+
+ /**
+ * Gets the use client mode flag. The {@link #getUseClientMode()} method
gets the value from the socket while
+ * this method gets its value from this instance's config.
+ * @since 3.11.0
+ */
+ protected boolean isClientMode() {
+ return isClientMode;
+ }
+
+ /**
+ * Gets the need client auth flag. The {@link #getNeedClientAuth()} method
gets the value from the socket while
+ * this method gets its value from this instance's config.
+ * @since 3.11.0
+ */
+ protected boolean isNeedClientAuth() {
+ return isNeedClientAuth;
+ }
+
+ /**
+ * Gets the want client auth flag. The {@link #getWantClientAuth()} method
gets the value from the socket while
+ * this method gets its value from this instance's config.
+ * @since 3.11.0
+ */
+ protected boolean isWantClientAuth() {
+ return isWantClientAuth;
+ }
+
+ /**
+ * Gets the cipher suites. The {@link #getEnabledCipherSuites()} method
gets the value from the socket while
+ * this method gets its value from this instance's config.
+ * @since 3.11.0
+ */
+ protected String[] getSuites() {
+ return suites;
+ }
+
+ /**
+ * Gets the protocol versions. The {@link #getEnabledProtocols()} method
gets the value from the socket while
+ * this method gets its value from this instance's config.
+ * @since 3.11.0
+ */
+ protected String[] getProtocols() {
Review Comment:
Returning arrays without making a defensive copy is probably a recipe for
future bugs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
