garydgregory commented on code in PR #455:
URL: https://github.com/apache/commons-compress/pull/455#discussion_r1439024770
##########
src/main/java/org/apache/commons/compress/archivers/zip/ZipSplitOutputStream.java:
##########
@@ -42,14 +48,20 @@ final class ZipSplitOutputStream extends OutputStream {
private static final long ZIP_SEGMENT_MIN_SIZE = 64 * 1024L;
private static final long ZIP_SEGMENT_MAX_SIZE = 4294967295L;
- private OutputStream outputStream;
+ private FileChannel currentChannel;
+ private FileRandomAccessOutputStream outputStream;
private Path zipFile;
private final long splitSize;
+ private long totalPosition;
private int currentSplitSegmentIndex;
private long currentSplitSegmentBytesWritten;
private boolean finished;
private final byte[] singleByte = new byte[1];
+ private List<Long> diskToPosition = new ArrayList<>();
+
+ private TreeMap<Long, Path> positionToFiles = new TreeMap<>();
Review Comment:
Is there going to be an issue here on case-insensitive file systems? Say,
Windows, macOS?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
